Skip to content

Support linux arm #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Support linux arm #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8ea3e4
Support linux arm
Nicell May 5, 2025
f37735c
drop alpha
Nicell May 5, 2025
e63e49c
I guess
Nicell May 5, 2025
a4ba984
22.04 lock
Nicell May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Test setup-foreman action
strategy:
matrix:
os: ["ubuntu-latest", "windows-latest", "macos-latest"]
os: ["ubuntu-22.04", "windows-latest", "macos-latest"]

runs-on: ${{ matrix.os }}
steps:
Expand All @@ -38,7 +38,7 @@ jobs:
name: Test setup-foreman action with working-directory
strategy:
matrix:
os: ["ubuntu-latest", "windows-latest", "macos-latest"]
os: ["ubuntu-22.04", "windows-latest", "macos-latest"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand All @@ -62,7 +62,7 @@ jobs:
name: Test allow-external-gitub-org false expect failure
strategy:
matrix:
os: ["ubuntu-latest"]
os: ["ubuntu-22.04"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
name: Test allow-external-gitub-org false expect success
strategy:
matrix:
os: ["ubuntu-latest"]
os: ["ubuntu-22.04"]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion foreman.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This file is used as a way to make sure that setup-foreman is functioning.

[tools]
rojo = { source = "Roblox/rojo", version = "0.6.0-alpha.1" }
rojo = { source = "Roblox/rojo", version = "6.0.0" }
selene = { source = "Kampfkarren/selene", version = "0.15.0" }
12 changes: 10 additions & 2 deletions src/foreman.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ function chooseRelease(

function chooseAsset(release: GitHubRelease): GitHubAsset | null {
let platformMatcher: (name: string) => boolean;
const arch = os.arch();

if (process.platform === "win32") {
platformMatcher = name =>
name.includes("windows") ||
name.includes("win64") ||
name.includes("win32");
} else if (process.platform === "darwin") {
const arch = os.arch();
if (arch === "x64") {
if (release.tag_name >= "v1.0.5") {
platformMatcher = name => name.includes("macos-x86_64");
Expand All @@ -66,7 +66,15 @@ function chooseAsset(release: GitHubRelease): GitHubAsset | null {
platformMatcher = name => name.includes("macos-arm64");
}
} else if (process.platform === "linux") {
platformMatcher = name => name.includes("linux");
if (arch === "x64") {
if (release.tag_name >= "v1.6.4") {
platformMatcher = name => name.includes("linux-x86_64");
} else {
platformMatcher = name => name.includes("linux");
}
} else {
platformMatcher = name => name.includes("linux-arm64");
}
} else {
throw new Error(`Unsupported platform "${process.platform}"`);
}
Expand Down
Loading