Skip to content

Conversation

jvogt23
Copy link
Contributor

@jvogt23 jvogt23 commented Jul 1, 2024

Description

Describe your pull request.
Created a way to override a robot's current position for testing purposes.

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

Test Case 1

  1. Step 1 - Run the stack, and under the tab Positions on the right of the main window, set any robot to any position other than auto
  2. Step 2 - Hit the reset button for that robot
  3. Step 3 - Change the goalie number
  4. Step 4 - Set any robot to any position other than auto, then set the goalie number to that robot

Expected result:???

  1. The robot selected should start behaving consistent with the position selected
  2. The robot should go back to whatever its default position is
  3. The robot moving out of "Goalie" status should change to Auto, and the robot selected should become a goalie.
  4. The robot should start by changing its position, then when it becomes the Goalie, the previous goalie should become auto, the UI should allow you to select that robot's position, and the UI should switch the new goalie's override to "Auto" and gray out the combo box so you can no longer change that robot's position.

Key Files to Review

Group 1 - namespace strategy

  • File 1 robot_factory_position.hpp and cpp
  • File 2 overriding_positions.hpp

Group 2 - UI

  • File 3 main_window.cpp
  • File 4 MainWindow.ui

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

jvogt23 and others added 3 commits October 14, 2024 20:49
automated style fixes

Co-authored-by: jvogt23 <jvogt23@users.noreply.github.com>
Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work!

automated style fixes

Co-authored-by: jvogt23 <jvogt23@users.noreply.github.com>
@jvogt23 jvogt23 requested a review from jacksherling December 9, 2024 03:16
@jvogt23 jvogt23 requested a review from shourikb January 20, 2025 01:54
Copy link
Contributor

@sid-parikh sid-parikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. the main thing i'd want to discuss is the choice of topics. everything else was just me being nitpicky, feel free to ignore

@jvogt23 jvogt23 requested a review from sid-parikh January 27, 2025 05:03
@sid-parikh
Copy link
Contributor

Thanks for making that change. I'm real excited for this feature. just a minor nitpick. also @shourikb @jacksherling has someone tested this? i only reviewed code

@jacksherling jacksherling merged commit 8e88b85 into ros2 Jan 29, 2025
2 checks passed
@jacksherling jacksherling deleted the test-mode branch January 29, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants