Skip to content

Conversation

sid-parikh
Copy link
Contributor

Description

Updates the stack to be dependent on ROS2 Humble (which is associated with Ubuntu 24)

Associated / Resolved Issue

Resolves # or ClickUp card

Design Documents

Link

Steps to Test

Test Case 1

  1. Step 1
  2. Step 2
  3. Step 3

Expected result:???

Key Files to Review

  • setup files primarily and cmake
  • minor changes have been made to

!! need follow up with a PR soon -- the "changelog" needs to moved to a useful format (Gdrive?)
(or just paste it into a PR description)

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

Copy link
Contributor

@jacksherling jacksherling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall
if you want we can update docs/source/installation.rst in this pr otherwise I can do it after we merge this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to include this?

Co-authored-by: Nathaniel Wert <N8.Wert.B@gmail.com>
@sid-parikh sid-parikh merged commit 80d5fa4 into ros2 Sep 15, 2024
0 of 2 checks passed
@sid-parikh sid-parikh deleted the james-vogt/update-ros2 branch September 15, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants