Ball placement obstacle with Stadium Shape on their ball placement #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y so that robots don't go through it
…s to make that into its own class
…t the drawer. Untested
…uest. for some reason, we must use the shape set stadium has instead of make stadium a shared pointer to add it to our static obstacles. drawing the stadium shape is also working correctly. the stadium shape will only be added as an obstacle if it is their ball placement.
sanatd33
requested changes
Oct 23, 2024
soccer/src/soccer/debug_drawer.cpp
Outdated
| dbg->set_color(color(qc)); | ||
| } | ||
|
|
||
| // void DebugDrawer::draw_stadium(rj_geometry::StadiumShape& stadium, const QColor& qc, const QString& layer) { |
soccer/src/soccer/debug_drawer.hpp
Outdated
| const QColor& qw = Qt::black, | ||
| const QString& layer = QString()); | ||
|
|
||
| // void draw_stadium(rj_geometry::StadiumShape& stadium, |
| rj_geometry::StadiumShape stadium = rj_geometry::StadiumShape{in.world_state->ball.position, bp_point, ball_obs.radius()}; | ||
|
|
||
| // for some reason adding the shared pointer below to our static obstacles breaks it, so we add the shape set it has instead. | ||
| // std::shared_ptr<rj_geometry::Shape> track_obs_ptr = std::make_shared<rj_geometry::Shape>(stadium); |
There was a problem hiding this comment.
this will be fixed when you add a move constructor
| ~StadiumShape() = default; | ||
|
|
||
| StadiumShape() = default; | ||
|
|
* initial test of tigers system * clean up and add comment * added line test * fix line issue * made comments and removed from settle * Fix Code Style On intermediate-pathgen (#2267) automated style fixes Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com> * make pr changes * add cache inter * start cacching intermediates * add params * use abs angle * Fix Code Style On intermediate-pathgen (#2269) automated style fixes Co-authored-by: sid-parikh <sid-parikh@users.noreply.github.com> --------- Co-authored-by: rishiso <rishisoni.5678@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: sanatd33 <sanatd33@users.noreply.github.com> Co-authored-by: petergarud <peter.garud04@gmail.com> Co-authored-by: sid-parikh <sid-parikh@users.noreply.github.com>
* change to humble * change dockerfile * remvoe werror switch --------- Co-authored-by: petergarud <peter.garud04@gmail.com>
updated files
* dribbler is stupid * use realism * add realism to simoulator cli run --------- Co-authored-by: petergarud <peter.garud04@gmail.com>
change to clang format 12
* start making wall planner * asdf1234 * complete waller planner * fix the fix the fix style
automated style fixes Co-authored-by: shourikb <shourikb@users.noreply.github.com>
jacksherling
changed the base branch from
ros2
to
revert-1970-fix-planner-node
jacksherling
changed the base branch from
revert-1970-fix-planner-node
to
ros2
jacksherling
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure rules compliance during their ball placement by staying out of the restricted area which is a stadium shape. We create a new geometry shape that represents this stadium shape. The stadium shape is composed of 2 circles and a rectangle. To create the shape, it takes in 2 points (that represent the centers of the circles) and a radius.
Associated / Resolved Issue
https://app.clickup.com/t/86b1vty49
Steps to Test
Test Case 1
Expected result:
Robot will move out of stadium shape drawn
Key Files to Review
Stadium Shape
Plan Request
Drawer
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.