Adding dynamic thresholding to pivot when kicking

[rishiso]

Description

Making angle rotation more precise when robot is shooting at further target

Associated / Resolved Issue

Related to ClickUp card

Steps to Test

1. Make every robot but one solo offense
2. Try taking shots from different distances

Expected result: Should not miss (as much)

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

soccer/src/soccer/planning/planner/rotate_path_planner.hpp:50

• [nitpick] The variable name 'kIsDoneAngleChangeThresh' implies a constant value. Consider renaming it to something like 'isDoneAngleChangeThresh_' to indicate its dynamic nature.

double kIsDoneAngleChangeThresh{1.0};

[sanatd33]

lgtm

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

soccer/src/soccer/planning/planner/rotate_path_planner.hpp:50

• [nitpick] Since the variable is mutable now, consider renaming it to remove the 'k' prefix to avoid suggesting it is a constant.

double kIsDoneAngleChangeThresh{1.0};

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

soccer/src/soccer/planning/planner/rotate_path_planner.hpp:50

• [nitpick] The name 'isDoneAngleChangeThresh' might be misleading now that the value is dynamic; consider renaming it to 'dynamicAngleThreshold' for better clarity.

double isDoneAngleChangeThresh{1.0};