add option for timing issues in tests #1914
Open
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hi @jerryfletcher21 I understand the problem and I think we should find a way to fix it. But I'm not a fan of modifying real code for the sake of testing, I would try to fix the problem from the testing side or at least make usage of the regular tools provider to coordinators. |
jerryfletcher21
force-pushed
the
timing-issues-tests
branch
from
d100a3c to
938daa7
Compare
|
@KoalaSat yes I agree that this is not fixing the problem. For now I am running it otherwise the tests fail. I leave this pull request as a reminder of this issue. If I have time I search for a way to fix it cleanly. |
|
Also it is really strange that the github action is failing, because this pull request does not change anything by default, the changes are there just if |
On my powerful machine, running tests resulted in some errors. After a bit of digging I found out that it was a timing issues. This PR adds a config option TIMING_EXTRA_IN_TESTS that when set to True, it take some time where it should so that the tests do not fail. If the config option is not present (default) nothing is changed. I had this issue very sporadically on my laptop, and every time when running on an other powerful machine.
jerryfletcher21
force-pushed
the
timing-issues-tests
branch
from
938daa7 to
ce0421f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On my powerful machine, running tests resulted in some errors. After a bit of digging I found out that it was a timing issues.
This PR adds a config option TIMING_EXTRA_IN_TESTS that when set to True, it takes some time where it should so that the tests do not fail.
If the config option is not present (default) nothing is changed.
I had this issue very sporadically on my laptop, and every time when running on an other powerful machine.
I run the tests without docker.
Checklist before merging
pip install pre-commit, thenpre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.