-
Notifications
You must be signed in to change notification settings - Fork 186
Add order description field #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d6806a1
to
d5b8cd7
Compare
70e3380
to
2449a38
Compare
@KoalaSat Updated the base branch and rebased. I think it's ready to be reviewed, please let me know if I should change anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work as usual @aftermath2 this will be indeed a very useful attribute for some users
Please accept a small tip for your work. Paste here a LN invoice with a long expiration date for 200,000 Satoshis
@KoalaSat @RobosatsDevFund Thank you!!
|
What does this PR do?
Fixes #1943.
This PR introduces a field for users to include contract terms, notes or other details about the order and its payment methods.
The field has a maximum length of 240 characters (discretionary, could be shorter) and its input in the maker form is visible only if advanced options are enabled.
Tests
test_trade_pipeline.py
Screenshots
Maker form
Maker form error
Order details
Checklist before merging
pip install pre-commit
, thenpre-commit install
. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.