Skip to content

Fix premium sorting in order book #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix premium sorting in order book #2278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9569d1
Fix premium sorting in order book
Libertrue Oct 9, 2025
7b83bca
Merge branch 'main' into fix-premium-sort-issue-2146
Libertrue Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions frontend/src/components/BookTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,19 @@ const BookTable = ({
: orders;
}, [showControls, orders, fav, paymentMethods]);

const sortModel = useMemo(() => {
if (fav.type === 1) {
// buyer - sort ascending to show best deals first (lowest premium)
return [{ field: 'premium', sort: 'asc' as const }];
} else if (fav.type === 0) {
// seller - sort descending to show best deals first (highest premium)
return [{ field: 'premium', sort: 'desc' as const }];
} else {
// no filter selected
return [];
}
}, [fav.type]);

if (!fullscreen) {
return (
<Paper
Expand All @@ -804,6 +817,7 @@ const BookTable = ({
sx={headerStyleFix}
localeText={localeText}
rows={filteredOrders}
sortModel={sortModel}
getRowId={(params: PublicOrder) => `${String(params.coordinatorShortAlias)}/${params.id}`}
loading={federation.loading}
columns={columns}
Expand Down Expand Up @@ -844,6 +858,7 @@ const BookTable = ({
rowHeight={3.714 * theme.typography.fontSize}
headerHeight={3.25 * theme.typography.fontSize}
rows={filteredOrders}
sortModel={sortModel}
loading={federation.loading}
columns={columns}
hideFooter={!showFooter}
Expand Down