Use "angle" instead of "direction" for text#53
Open
GravisZro wants to merge 1 commit intoRobotips:masterfrom
Open
Use "angle" instead of "direction" for text#53GravisZro wants to merge 1 commit intoRobotips:masterfrom
GravisZro wants to merge 1 commit intoRobotips:masterfrom
Conversation
GravisZro
force-pushed
the
use-angle
branch
from
7c48470 to
5ac87e2
Compare
Member
|
I agree with angle instead of direction (direction was the term used in kicad 4 model), but the transform should not be place into model. |
Contributor
Author
|
Moving the QTransform into the DrawTextItem is ugly (requires adding a signal for when |
This replaces all instances of direction/setDirection with angle/setAngle for the DrawText type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces all instances of direction/setDirection with angle/setAngle for the DrawText type. Internally a QTransform is also stored so that the transform matrix doesn't have to be continually recalculated on every paint event. This also more closely matches the KiCAD file format which also uses a numerical value for the angle.
Testing is needed before merging.