chore: Remove some omnichannel tech debt -2 #35854

KevLehman · 2025-04-22T20:58:08Z

Proposed changes (including videos or screenshots)

Removes 2 callbacks and replace them with patchfunctions

Use promise.all where applicable

Moved check calls to the meteor method calling the function, which should make easier to remove the meteor method at some point

Removed duplicated db calls for validation of data

Attempting new strategy: instead of find-check-delete, delete and then check. This reduces one DB call (no check) and uses the result from the delete call to check if the value was valid

Projections & types for projections

Removed unused file

Use ajv for department/id/agents endpoint

Issue(s)

https://rocketchat.atlassian.net/browse/CTZ-87

Steps to test or reproduce

Further comments

This pull request focuses on removing technical debt within the omnichannel components of the Rocket.Chat project. Key changes include:

Type Safety and Validation Enhancements:
- Added type validation for department agents endpoints and refined type definitions for department agent operations, improving type safety and removing redundant parameter checks.
- Updated various Meteor methods (livechat:saveAgentInfo, livechat:addMonitor, livechat:removeMonitor, livechat:removeTag, livechat:removeUnit, livechat:saveTag) to include input validation using Meteor's check package, enhancing robustness against invalid inputs.
Performance Improvements:
- Refactored asynchronous operations in several files (livechat.ts, config.ts) to run concurrently using Promise.all, improving performance and code structure.
Code Refactoring and Simplification:
- Modified the LivechatDepartmentEE model to make the businessUnit parameter optional and extracted core query logic into a helper method, improving maintainability.
- Refactored the findEnabledWithAgentsAndBusinessUnit method to reuse existing logic, reducing code duplication.
- Updated REST API typings and validation schemas for Livechat department agents, introducing pagination support and correcting schema mismatches.
Type Definitions and Static Analysis:
- Enhanced type safety by adding explicit TypeScript types to database query results and modifying type definitions in various methods and models, aligning with TypeScript best practices.

These changes collectively aim to improve the performance, maintainability, and type safety of the omnichannel components in the Rocket.Chat codebase.

dionisio-bot · 2025-04-22T20:58:12Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2025-04-22T20:58:12Z

⚠️ No Changeset found

Latest commit: 37c9f22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-04-22T21:11:38Z

PR Preview Action v1.6.1
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35854/
Built to branch `gh-pages` at 2025-05-07 14:57 UTC. Preview will be ready when the GitHub Pages deployment is complete.

codecov · 2025-04-22T21:12:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (af86fce) to head (37c9f22).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #35854      +/-   ##
===========================================
+ Coverage    64.59%   64.76%   +0.17%     
===========================================
  Files         3223     3072     -151     
  Lines        95227    91973    -3254     
  Branches     17845    17512     -333     
===========================================
- Hits         61511    59566    -1945     
+ Misses       30821    29659    -1162     
+ Partials      2895     2748     -147

Flag	Coverage Δ
e2e	`58.10% <ø> (+<0.01%)`	⬆️
unit	`71.94% <ø> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kodus-ai · 2025-04-24T13:52:34Z

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

packages/rest-typings/src/v1/omnichannel.ts

apps/meteor/app/livechat/server/lib/departmentsLib.ts

apps/meteor/app/livechat/server/methods/saveAgentInfo.ts

apps/meteor/app/livechat/server/api/v1/config.ts

apps/meteor/ee/app/livechat-enterprise/server/methods/removeUnit.ts

apps/meteor/ee/app/livechat-enterprise/server/lib/LivechatEnterprise.ts

apps/meteor/app/livechat/server/api/v1/config.ts

apps/meteor/ee/server/models/raw/LivechatDepartment.ts

kodus-ai · 2025-04-24T14:33:50Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kodus-ai · 2025-04-24T14:47:00Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/app/livechat/server/api/lib/livechat.ts

packages/rest-typings/src/v1/omnichannel.ts

apps/meteor/app/livechat/server/api/v1/config.ts

kodus-ai · 2025-04-24T14:53:20Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kodus-ai · 2025-04-24T14:57:33Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

kodus-ai · 2025-04-24T15:31:51Z

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration

Interacting with Kody

Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.
Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration

Review Options

The following review options are enabled or disabled:

Options	Enabled
Security	✅
Code Style	✅
Kody Rules	✅
Refactoring	✅
Error Handling	✅
Maintainability	✅
Potential Issues	✅
Documentation And Comments	✅
Performance And Optimization	✅
Breaking Changes	❌

Access your configuration settings here.

apps/meteor/app/livechat/server/lib/departmentsLib.ts

KevLehman added this to the 7.7.0 milestone Apr 23, 2025

Base automatically changed from chore/todo to develop April 23, 2025 22:03

KevLehman added 13 commits April 24, 2025 07:44

todo-1

687e8ff

fixes

b29511d

remove meteor.error usage

de2c885

why this feels slow

925b1b1

saveAgentInfo optz

2e40192

optimize

baf726b

always return all

4320202

fix

cbafe16

fix

126ad87

rm

711a385

why were we importing this in the first place

a2f6110

fix fix

9b42532

test

7713b63

KevLehman force-pushed the chore/todo-2 branch from e286051 to 7713b63 Compare April 24, 2025 13:52