Skip to content

chore: apply useQuery on InviteUsers #35861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 29, 2025
Merged

chore: apply useQuery on InviteUsers #35861

merged 6 commits into from
Apr 29, 2025

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Apr 23, 2025

ARCH-1579

Proposed changes (including videos or screenshots)

In dev mode, invite links were being generated 2 times due to useEffect

  • replace endpoint call in useEffect in favor of useQuery
  • handle error state
  • handle loading state
  • handle success state

Issue(s)

Steps to test or reproduce

Further comments


This pull request focuses on refactoring the InviteUsers functionality within the Rocket.Chat application. The main change involves applying useQuery for data fetching in the InviteUsers component. The update includes the removal of existing error handling and the Callout component, which may affect error visibility and user experience. To address error handling, a new component, InviteUsersError, is introduced to manage and display errors during the user invitation process. Additionally, a new loading component, InviteUsersLoading, is added to enhance the user interface during the invitation process. The InviteUsersWithData component is refactored to incorporate React Query for improved data management and state handling. While the code is generally well-structured, there are suggestions for further improvements in error handling and type safety across the new components.

Copy link
Contributor

dionisio-bot bot commented Apr 23, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 342df8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

kodus-ai bot commented Apr 23, 2025

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

Copy link
Contributor

github-actions bot commented Apr 23, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35861/

Built to branch gh-pages at 2025-04-28 17:44 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 61.18%. Comparing base (25303e3) to head (342df8f).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35861      +/-   ##
===========================================
- Coverage    61.18%   61.18%   -0.01%     
===========================================
  Files         3157     3161       +4     
  Lines        74670    74684      +14     
  Branches     16677    16679       +2     
===========================================
+ Hits         45687    45693       +6     
- Misses       25879    25893      +14     
+ Partials      3104     3098       -6     
Flag Coverage Δ
e2e 57.84% <15.62%> (-0.01%) ⬇️
unit 75.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

kodus-ai bot commented Apr 23, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

This comment was marked as duplicate.

1 similar comment

This comment was marked as duplicate.

@juliajforesti juliajforesti marked this pull request as ready for review April 24, 2025 14:42
@juliajforesti juliajforesti requested a review from a team as a code owner April 24, 2025 14:42
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have some snapshots and a11y tests in these screens

Copy link

kodus-ai bot commented Apr 24, 2025

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Security
Code Style
Kody Rules
Refactoring
Error Handling
Maintainability
Potential Issues
Documentation And Comments
Performance And Optimization
Breaking Changes

Access your configuration settings here.

This comment was marked as duplicate.

@juliajforesti juliajforesti added this to the 7.7.0 milestone Apr 28, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 29, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 29, 2025
@ggazzo ggazzo merged commit 348e8ba into develop Apr 29, 2025
49 checks passed
@ggazzo ggazzo deleted the chore/invite-users branch April 29, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants