fix: encoding of special characters in text attachments #35863
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 0bc6d98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35863 +/- ##
===========================================
- Coverage 64.91% 64.83% -0.08%
===========================================
Files 3110 3259 +149
Lines 93605 96777 +3172
Branches 17788 18035 +247
===========================================
+ Hits 60763 62749 +1986
- Misses 30054 31100 +1046
- Partials 2788 2928 +140
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
cardoso
changed the title
…nto SUP-725-api-txt-attachment-enc
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
![kodus-ai[bot]](https://avatars.githubusercontent.com/in/413034?s=60&v=4){kind=small}
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
…nto SUP-725-api-txt-attachment-enc
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
|
@gabriellsh escaping inline is trickier, so I think it's better to fix just the code block use case for now. |
Given that this is a prioritized ticket, it indicates a significant client impact. To fully address the issue and prevent recurring complaints, we should aim to fix both inline and code block escaping, rather than just the code block scenario. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cardoso
force-pushed
the
SUP-725-api-txt-attachment-enc
branch
from
19e3289 to
e2e5fc4
Compare
…nto SUP-725-api-txt-attachment-enc
Proposed changes (including videos or screenshots)
This PR fixes an issue when posting messages via the API: special characters like
><and&symbol in code blocks inside text attachments are displayed as>,<, and&.Issue(s)
https://rocketchat.atlassian.net/browse/SUP-725
Steps to test or reproduce
API Endpoint: /api/v1/chat.postMessage
Example API Body:
{ "channel": "#COMM_EMOJI_TEST", "text": "```text\n TEST > TEST \n```", "attachments": [{ "text": "```text\n TEST > TEST\n```" }] }Result: The
>symbol becomes>in the attachment text but not in the message body.Further comments
Pull Request Description:
This pull request addresses an issue in the Rocket.Chat repository related to the encoding of special characters in attachments. The changes are made in the
DefaultAttachment.tsxfile within theapps/meteor/client/components/message/content/attachmentsdirectory. The update introduces the use of the Markup component from the gazzodown library to handle markdown content in attachments. Additionally, it implements conditional rendering based on the presence of themdproperty to ensure proper encoding and display of special characters. The source branch for this fix isSUP-725-api-txt-attachment-enc, and it targets thedevelopbranch.