Skip to content

fix(ui-client): remove invalid transparent color token from PageHeader#38578

Open
roy-abir05 wants to merge 1 commit intoRocketChat:developfrom
roy-abir05:fix/ui-client-remove-invalid-transparent-color
Open

fix(ui-client): remove invalid transparent color token from PageHeader#38578
roy-abir05 wants to merge 1 commit intoRocketChat:developfrom
roy-abir05:fix/ui-client-remove-invalid-transparent-color

Conversation

@roy-abir05
Copy link

Proposed changes (including videos or screenshots)

The PageHeader component was previously passing the string 'transparent' to the borderBlockEndColor prop. This is not a valid color token in the Fuselage design system and caused an invalid color: transparent error in the browser console.

This PR fixes the issue by:

  1. Passing undefined instead of 'transparent' when no border color is required.
  2. Conditionally setting borderBlockEndWidth to 'none' when the border is hidden. This prevents the browser from rendering a default-colored border (visible as a white line) when a width is present but the color is undefined.

Screenshots:
Before:
Before

After:
After

Issue(s)

Fixes #38577

Steps to test or reproduce

  1. Log in as any user.
  2. Navigate to the Home page (/home).
  3. Open Developer Tools (F12) -> Console.
  4. Verify: The invalid color: transparent error does not appear.
  5. Verify: There is no unwanted border line visible below the header text.

Further comments

This change satisfies Fuselage's strict token requirements by ensuring only valid tokens or undefined are passed to the Box component.

Pass undefined instead of invalid 'transparent' color to fix console warnings.
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Feb 10, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: 9634a1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@roy-abir05
Copy link
Author

Hi team!
Just a friendly bump on this.
The PR fixes the console warning and visual regression on the Home page header. CI is green and the CLA is signed. Let me know if you need any adjustments or if this is good to go!

@KevLehman KevLehman added the valid A valid contribution where maintainers will review based on priority label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

valid A valid contribution where maintainers will review based on priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Console warning "invalid color: transparent" on Home Page Header

3 participants