fix(message-parser): parse emojis and inline elements inside headings#39197
Open
Harshit2405-2004 wants to merge 2 commits intoRocketChat:developfrom
Open
fix(message-parser): parse emojis and inline elements inside headings#39197Harshit2405-2004 wants to merge 2 commits intoRocketChat:developfrom
Harshit2405-2004 wants to merge 2 commits intoRocketChat:developfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: f9b5f72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughGrammar and tests updated to correctly parse emoji and inline markdown inside heading blocks; a patch changeset documents the fix. Tests assert emoji can appear at start, end, and intermixed within headings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labelstype: bug 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/message-parser/src/grammar.pegjs">
<violation number="1" location="packages/message-parser/src/grammar.pegjs:151">
P2: HeadingChunk now repeats Inline, which can consume EndOfLine; this allows a heading to absorb multiple subsequent non-empty lines into the same heading instead of stopping at the line boundary.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…ent newline absorptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #33067.
The PEG grammar in
message-parserpreviously restricted Heading chunks to rawHeadingStringtokens. This prevented nested inline elements, like Emojis (# :smile:) and bold variations, from being parsed correctly into their structural AST node objects.This PR updates the parser grammar block to evaluate standard
Inlinerules recursively insideHeadingcomponents, restoring native markdown formatting behavior without negatively impacting simple text rendering. Verified by expanding testing capabilities for emoji-nested headlines.Summary by CodeRabbit