Skip to content

Commit b75bcc6

Browse files
committed
fix: use Helmet to update page title
1 parent 7281036 commit b75bcc6

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

ui/src/components/header/header.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { useLogout } from 'data-services/hooks/auth/useLogout'
33
import { Button, ButtonTheme } from 'design-system/components/button/button'
44
import buttonStyles from 'design-system/components/button/button.module.scss'
55
import { Icon, IconTheme, IconType } from 'design-system/components/icon/icon'
6+
import { Helmet } from 'react-helmet-async'
67
import { Link, useLocation } from 'react-router-dom'
78
import { APP_ROUTES, LANDING_PAGE_URL } from 'utils/constants'
89
import { STRING, translate } from 'utils/language'
@@ -17,11 +18,13 @@ export const Header = () => {
1718
const location = useLocation()
1819
const { user } = useUser()
1920
const { logout, isLoading: isLogoutLoading } = useLogout()
20-
21-
usePageTitle()
21+
const pageTitle = usePageTitle()
2222

2323
return (
2424
<header className={styles.header}>
25+
<Helmet>
26+
<title>{pageTitle}</title>
27+
</Helmet>
2528
<Link to="/" className={styles.logoContainer}>
2629
<img
2730
alt="Antenna"

ui/src/utils/usePageTitle.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,5 @@ export const usePageTitle = () => {
3030
setPageTitle(pageTitle)
3131
}, [pageBreadcrumb, projectBreadcrumb, mainBreadcrumb, detailBreadcrumb])
3232

33-
useEffect(() => {
34-
document.title = pageTitle
35-
}, [pageTitle])
36-
3733
return pageTitle
3834
}

0 commit comments

Comments
 (0)