-
Notifications
You must be signed in to change notification settings - Fork 5
Bulk actions #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk actions #460
Conversation
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TODO for @mihow : At least add Family level taxa choices |
This one is working great. However one change I purpose is that if you select multiple Occurrences and then use the Apply ID quick action, it should only show the taxa choices that are common among all the choices. Right now it shows all of the taxa from all of the choices. I'm hoping there is a reduce function of some sort that can make that easy! And will you go ahead and try to implement the Suggest ID search for the bulk select? OR! As an alternative, we could try a new feature: Under Apply ID, add a "Recent" section of taxa that were recently applied (maybe saved in the current browser session). This would be pretty handy in multiple cases. But also you could use it as an alternative to search. Because you can search & apply a custom ID to a single Occurrence, then it will show up in the recent column. Thoughts? |
return { | ||
isLoading, | ||
isSuccess, | ||
createIdentifications: async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! The async really pays off here. I see all 16 requests fire off at once and the backend seems to respond quickly.
One experience detail: if you are sorting by score, as soon as you apply a batch of IDs, the Occurrences disappear because they now have a score of 1. Perhaps this is a feature! Because then you are automatically presented with the next batch to verify, but at first this was confusing. Here are some ideas to consider:
|
Ah yes, I should definitely only show the common choices! Also once BE is returning more levels, we can do this without risking excluding some choices that are actually common. But anyhow, I will go ahead and fix this! For suggest ID, I think yes, but could probably need a bit of thinking through UX wise and I don't see it as a blocker for this feature. I think the thing you pointed out above, error handling and the sticky header thing I mentioned in PR descriptions are the most important things to fix, so will do that first! :) I like your suggestion with showing recent options, seems handy! Probably pretty straight forward design wise as well. I'll see if I include here, or in a separate branch... |
…form into feature/bulk-actions
I have updated the PR description with current status of this task. I think this one could get merged as is and we can handle what is left as separate issues. Hopefully it's still useful even though we of course also want the taxon updates in order to show better choices :) |
Reminders for Anna:
Update: fixed with last 2 commits 👇 |
I love using the new persistent modal while adding to the selection! Merging! |
In this PR we setup bulk actions for occurrences. At the moment it's possible to agree in bulk and also to apply ID in bulk. The apply options are currently a list of all the common ranks among the selected occurrences. Also we will show the recently applied identification as an apply option.
Comments for later:
Screenshots: