-
Notifications
You must be signed in to change notification settings - Fork 5
Fixes to the session captures timeline data #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: ami/main/api/views.py
Did you find this useful? React with a 👍 or 👎 |
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zeroline: false, | ||
fixedrange: true, | ||
range: [session.startDate, session.endDate], | ||
range: [new Date(session.startDate), new Date(session.endDate)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session.startDate
is already a date, any reason we are creating a new date? Same in some other cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I was experimenting with date formats was trying different approaches. Reverting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ui/src/pages/session-details/playback/activity-plot/activity-plot.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for fixing this, it was bugging me as well, especially clicking a spike and the sometimes outshined capture graph. I think it looks great, just that case when no detections I thought looked a bit strange, but no biggie!
Pushed a tiny fix to format numbers in the capture picker.
Standardize text case of labels Co-authored-by: Anna Viklund <annamariaviklund@gmail.com>
…lot.tsx Co-authored-by: Anna Viklund <annamariaviklund@gmail.com>
Before:


After:
Before:


After: