Skip to content

Conversation

mihow
Copy link
Collaborator

@mihow mihow commented Aug 8, 2024

  • Fixes the issue where clicking on a "spike" (interval) activates the first capture in the interval, which may have no detections and feels confusing. Now when clicking on a spike the capture with the most detections is activated instead of the first capture in the interval.
  • Fixes the num captures displayed per interval. Now uses the mode average of detections from captures within the interval (ignoring zeros). Before it was a sum of all detections in the interval, which felt misleading.
  • Fixes the issue where capture ticks were not visible if the number of detections is high. Now the captures Y axis has its own range (centered around its average) that is separate from the range of the detections y axis.
  • Added vertical grid lines on the hour marks! Just a quick way to do it until we can add labels in Add vertical markers every hour #482

Before:
image
After:
image

Before:
image
After:
image

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 3453ec5
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/66b541a28426470008b02e46
😎 Deploy Preview https://deploy-preview-499--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 34
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow requested a review from annavik August 8, 2024 01:24
Copy link

sentry-io bot commented Aug 8, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ami/main/api/views.py

Function Unhandled Issue
timeline ValidationError: 'Fyll i ett heltal.' /api/v2/eve...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 3453ec5
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/66b541a3325e6400082e52c3
😎 Deploy Preview https://deploy-preview-499--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

zeroline: false,
fixedrange: true,
range: [session.startDate, session.endDate],
range: [new Date(session.startDate), new Date(session.endDate)],
Copy link
Member

@annavik annavik Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session.startDate is already a date, any reason we are creating a new date? Same in some other cases.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, I was experimenting with date formats was trying different approaches. Reverting!

Copy link
Member

@annavik annavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skärmavbild 2024-08-08 kl  17 34 10

When number of detections is 0, can we make the y axis still start at 0?

Copy link
Member

@annavik annavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing this, it was bugging me as well, especially clicking a spike and the sometimes outshined capture graph. I think it looks great, just that case when no detections I thought looked a bit strange, but no biggie!

Pushed a tiny fix to format numbers in the capture picker.

@mihow
Copy link
Collaborator Author

mihow commented Aug 8, 2024

Skärmavbild 2024-08-08 kl 17 34 10 When number of detections is 0, can we make the y axis still start at 0?

Fixed!

@mihow mihow merged commit 7efa307 into main Aug 8, 2024
@mihow mihow deleted the fix/timeline-data branch August 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants