Skip to content

Conversation

annavik
Copy link
Member

@annavik annavik commented Aug 19, 2024

In this PR we make it possible for logged in users to update email and password. Before you had to contact an administrator to do so.

Some issues to look into:

  • BE response when updating email is successful, but the email is just partially saved (new email is not returned with user info, in admin the new email is only visible in some places).
    • Update: fixed!
  • BE response when updating password is successful, but the password seems to be the same.
    • Update: fixed!

User flow:

We show email and password as static values, but with edit buttons visible.
Skärmavbild 2024-08-19 kl  14 25 37

On edit button click, a mini form shows up. The mini form will have its own isolated state. This is because we are making special backend calls on email/password update, outside the user info update.
Skärmavbild 2024-08-19 kl  14 25 48

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit ba03960
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/66c4d401603a400008a2878b
😎 Deploy Preview https://deploy-preview-525--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 32
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit ba03960
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/66c4d401a8d6b60008a3581b
😎 Deploy Preview https://deploy-preview-525--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow
Copy link
Collaborator

mihow commented Aug 20, 2024

@annavik there was one required setting missing in the Django Djoser settings (https://djoser.readthedocs.io/en/latest/settings.html#password-reset-confirm-url). I updated that and I am able to reset my password!

The one thing I noticed is that I couldn't use my password manager with the form fields. When I try to make a selection the focus jumps to the next field.

image

@annavik
Copy link
Member Author

annavik commented Aug 20, 2024

Thanks a lot @mihow!! Those URL:s seemed to fix things here and also some problems I had when I started #526 got solved.

I will look into that password manager problem, what manager is that do you use?

@annavik annavik changed the title [Draft] Make it possible for logged in users to update email and password Make it possible for logged in users to update email and password Aug 21, 2024
@annavik annavik marked this pull request as ready for review August 21, 2024 08:50
@annavik annavik requested a review from mihow August 21, 2024 08:50
@annavik
Copy link
Member Author

annavik commented Aug 21, 2024

@mihow I added an issue about the password manager thing, I suspect could be a similar situation for password reset, at least worth double checking. Marking this one as ready for review so we can get it out of the way! :)

@annavik annavik added this to the Limited Public Launch milestone Aug 21, 2024
@mihow mihow merged commit 4715f24 into main Aug 22, 2024
6 checks passed
@mihow mihow deleted the feature/update-email-password branch August 22, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants