Skip to content

Conversation

annavik
Copy link
Member

@annavik annavik commented Aug 22, 2024

Hide sign up from UI and make user registration disabled from API as well (make endpoint only possible to call for admin users). When we have the waitlist, we can add a link to it from the login page.

@annavik annavik requested a review from mihow August 22, 2024 07:36
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit d2cb85d
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/66d905a2e4b858000877e197
😎 Deploy Preview https://deploy-preview-536--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 33
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

"current_user": "ami.users.api.serializers.CurrentUserSerializer",
},
"PERMISSIONS": {
"user_create": ["rest_framework.permissions.IsAdminUser"],
Copy link
Member Author

@annavik annavik Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you would do it like this @mihow? I had a look here: https://djoser.readthedocs.io/en/latest/settings.html#permissions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding this setting. Admin for user_create is perfect for the demo. I will make it environment-specific next week.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit d2cb85d
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/66d905a2d1dd5d0008aea264
😎 Deploy Preview https://deploy-preview-536--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow force-pushed the chore/disable-sign-up branch from af3c59c to d2cb85d Compare September 5, 2024 01:13
@mihow mihow merged commit d446172 into main Sep 5, 2024
6 checks passed
@mihow mihow deleted the chore/disable-sign-up branch September 5, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants