Fix broken thumbnails for detections without crops

ami/main/migrations/0037_alter_detection_path_and_more.py

@@ -0,0 +1,25 @@
+# Generated by Django 4.2.10 on 2024-09-04 23:22
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+# Method to convert blank path to null in bulk
+def convert_blank_path_to_null(apps, schema_editor):
+    Detection = apps.get_model("main", "Detection")
+    Detection.objects.filter(path="").update(path=None)
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("main", "0036_event_calculated_fields_updated_at_and_more"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="detection",
+            name="path",
+            field=models.CharField(blank=True, max_length=255, null=True),
+        ),
+        migrations.RunPython(convert_blank_path_to_null, reverse_code=migrations.RunPython.noop),
+    ]

ami/main/models.py

@@ -1695,7 +1695,7 @@ class Detection(BaseModel):
     #         upload_to="detections",
     #     ),
     # )
-    path = models.CharField(max_length=255, blank=True)
+    path = models.CharField(max_length=255, blank=True, null=True)
 
     occurrence = models.ForeignKey(
         "Occurrence",
@@ -1912,7 +1912,7 @@ def duration_label(self) -> str | None:
         return ami.utils.dates.format_timedelta(duration)
 
     def detection_images(self, limit=None):
-        for url in Detection.objects.filter(occurrence=self).values_list("path", flat=True)[:limit]:
+        for url in Detection.objects.filter(occurrence=self).exclude(path=None).values_list("path", flat=True)[:limit]:
             yield urllib.parse.urljoin(_CROPS_URL_BASE, url)
 
     @functools.cached_property

ami/ml/models/pipeline.py

@@ -226,7 +226,7 @@ def save_results(results: PipelineResponse, job_id: int | None = None) -> list[m
         ).first()
         if existing_detection:
             if not existing_detection.path:
-                existing_detection.path = detection_resp.crop_image_url or ""
+                existing_detection.path = detection_resp.crop_image_url or None
                 existing_detection.save()
                 print("Updated existing detection", existing_detection)
             detection = existing_detection