Skip to content

Conversation

mihow
Copy link
Collaborator

@mihow mihow commented Sep 9, 2024

Previously the ML backend was managing crops itself and pushing them directly to S3. This is no longer the case, the ML backend returns just bounding boxes and the platform must create the cropped images for web display.

  • Removes hardcoded paths to the S3 storage URLs that the ML backend was using
  • Configures detection crops to use Django's storage backend (which connects to our Compute Canada object store)
  • Adds methods for finding and creating missing crops - with both a management command and a background task.
  • Adds generators for creating test image data for automated testing & dev environments.
  • Detection crops are created after a pipeline processing request is returned from an ML backend

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 2e6423d
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/66e2079d3ff2c900085d2b0c
😎 Deploy Preview https://deploy-preview-564--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit 2e6423d
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/66e2079d6ea2e700083de6ce
😎 Deploy Preview https://deploy-preview-564--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 30
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow merged commit 6a4f185 into main Sep 11, 2024
8 checks passed
@mihow mihow deleted the fix/missing-crops branch September 11, 2024 21:25
Copy link

sentry-io bot commented Sep 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: MISCONF Redis is configured to save RDB snapshots, but it is currently not able to persist on dis... ami.jobs.tasks.run_job View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant