Skip to content

Conversation

vanessavmac
Copy link
Collaborator

@vanessavmac vanessavmac commented Sep 16, 2024

Addressed the 2 points in #445:

  1. Restrict number of species if many in top species chart
  2. Hover label is sometimes a bit repetitive, for example in top species chart

The last item "Detections per hour chart is a bit strange" remains unresolved. See this comment @annavik : #445 (comment)

@vanessavmac vanessavmac linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit d928607
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/66e8a223b39ab10008769d70
😎 Deploy Preview https://deploy-preview-577--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for ami-dev ready!

Name Link
🔨 Latest commit d928607
🔍 Latest deploy log https://app.netlify.com/sites/ami-dev/deploys/66e8a223555de80008444cbc
😎 Deploy Preview https://deploy-preview-577--ami-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28
Accessibility: 89
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow changed the title 445 small backend issues related to plots Update top species chart Sep 17, 2024
@mihow
Copy link
Collaborator

mihow commented Sep 17, 2024

Thanks @vanessavmac! This looks good!

I updated the title of this PR, how about we focus it on the species chart and fix #387 here as well? Will you:

  1. Add the top species chart to the project overview
  2. Flip the chart so the top species count is on top rather than the bottom? I'm not sure when that happened!

image
image

@vanessavmac
Copy link
Collaborator Author

Hi @mihow, thanks for the feedback! I've opened PR #580 which includes the 2 changes you requested for the project overview. PR #580 and #577 complement one another.

@vanessavmac vanessavmac self-assigned this Sep 17, 2024
@mihow
Copy link
Collaborator

mihow commented Sep 17, 2024

okay thanks, merging this one then!

@mihow mihow merged commit f4807a1 into main Sep 17, 2024
6 checks passed
@mihow mihow deleted the 445-small-backend-issues-related-to-plots branch September 17, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small backend issues related to plots
2 participants