Fix broken docker compose start-up #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docker Compose configuration so that the required Docker network is automatically created if it doesn't exist rather than being treated as external.
- Removed the "external: true" flag from the antenna_network configuration
- Adjusted the network declaration to enable auto-creation of the network
Comments suppressed due to low confidence (1)
docker-compose.yml:160
- Removing the 'external: true' flag enables Docker Compose to automatically create the network. Consider adding a comment in the file to explain that this change ensures the network is created if it doesn't exist, which can help future maintainers understand the rationale.
external: true
✅ Deploy Preview for antenna-preview canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Docker network was required to exist before starting the compose stack. This change fixes that so the network will be created if it does not already exist.