-
Notifications
You must be signed in to change notification settings - Fork 5
Add frontend support for taxa tags #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for antenna-ood ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mihow
added a commit
that referenced
this pull request
May 16, 2025
* feat: added support for tag creation for a given taxon * chore: moved Tag<->Taxon many2many to the Taxon model * feat: added the Tag admin model * feat: added custom assign_tags action to the TaxonViewSet to assign tags for a given taxon and return the assigned tags filtered by project * fixed formatting * merged migrations * feat: added tags to the Taxon admin model * feat: added global tags * added db migration * feat: show global tags if there is an active project * feat: added or based taxon filtering by tag_id * chore: renamed TaxonTagFilterBackend * fix: fixed filtering tags by project_id in the TaxonViewSet list * Add frontend support for taxa tags (#828) * feat: setup UI for taxon tags * feat: prepare UI controls for tag filtering * feat: hook up UI tags with backend * fix: update filter key from tag -> tag_id * fixed Taxon List tags column name * feat: added tags inverse filter * feat: return global tags with project tags * chore: reset tag migrations, add default tags * fix: remove invalid field in taxa list query * chore: add type hints for reverse relationships --------- Co-authored-by: Anna Viklund <annamariaviklund@gmail.com> Co-authored-by: Michael Bunsen <notbot@gmail.com>
annavik
added a commit
that referenced
this pull request
Jul 4, 2025
* feat: added support for tag creation for a given taxon * chore: moved Tag<->Taxon many2many to the Taxon model * feat: added the Tag admin model * feat: added custom assign_tags action to the TaxonViewSet to assign tags for a given taxon and return the assigned tags filtered by project * fixed formatting * merged migrations * feat: added tags to the Taxon admin model * feat: added global tags * added db migration * feat: show global tags if there is an active project * feat: added or based taxon filtering by tag_id * chore: renamed TaxonTagFilterBackend * fix: fixed filtering tags by project_id in the TaxonViewSet list * Add frontend support for taxa tags (#828) * feat: setup UI for taxon tags * feat: prepare UI controls for tag filtering * feat: hook up UI tags with backend * fix: update filter key from tag -> tag_id * fixed Taxon List tags column name * feat: added tags inverse filter * feat: return global tags with project tags * chore: reset tag migrations, add default tags * fix: remove invalid field in taxa list query * chore: add type hints for reverse relationships --------- Co-authored-by: Anna Viklund <annamariaviklund@gmail.com> Co-authored-by: Michael Bunsen <notbot@gmail.com>
mihow
added a commit
that referenced
this pull request
Aug 5, 2025
* Add support for Taxa Tags (#830) * feat: added support for tag creation for a given taxon * chore: moved Tag<->Taxon many2many to the Taxon model * feat: added the Tag admin model * feat: added custom assign_tags action to the TaxonViewSet to assign tags for a given taxon and return the assigned tags filtered by project * fixed formatting * merged migrations * feat: added tags to the Taxon admin model * feat: added global tags * added db migration * feat: show global tags if there is an active project * feat: added or based taxon filtering by tag_id * chore: renamed TaxonTagFilterBackend * fix: fixed filtering tags by project_id in the TaxonViewSet list * Add frontend support for taxa tags (#828) * feat: setup UI for taxon tags * feat: prepare UI controls for tag filtering * feat: hook up UI tags with backend * fix: update filter key from tag -> tag_id * fixed Taxon List tags column name * feat: added tags inverse filter * feat: return global tags with project tags * chore: reset tag migrations, add default tags * fix: remove invalid field in taxa list query * chore: add type hints for reverse relationships --------- Co-authored-by: Anna Viklund <annamariaviklund@gmail.com> Co-authored-by: Michael Bunsen <notbot@gmail.com> * chore: remove unused import * fix: pass project ID when assigning tags * chore: skip adding initial tags to the database * fix: update migration deps * fix: revert caption update to fix build * feat: put tags feature behind feature flag * feat: disable tag filters if no tags for project * chore: fix migration ordering * feat: store feature flags with project * fix: return feature flags as a dictionary in API response * style: simplify tags form --------- Co-authored-by: Mohamed Elabbas <hack1996man@gmail.com> Co-authored-by: Michael Bunsen <notbot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we suggest UI controls for adding tags to taxa, to help us bring some order to the data. See #825 for background.
Backend needs
The current solution is using dummy data. To complete this, we need to add a new field to the database. Also we need following API actions exposed:
Screenshots