Add unknown species filter control #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for antenna-ood ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
annavik
changed the title
annavik
changed the title
|
What do you think about using this as a catch-all filter component for fixed value queries? the current ones I'd like to use are:
|
mihow
approved these changes
May 16, 2025
mihow
reviewed
May 16, 2025
| return queryset | ||
|
|
||
|
|
||
| class TaxonUnknownSpeciesFilter(filters.BaseFilterBackend): |
There was a problem hiding this comment.
Great work implementing this filter! This follows all of my favorite conventions.
…nickLab/antenna into feat/unknown-species-filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add a dedicated filter control for unknown species. We also extend the backend filtering with this new query param.
This is how I suggest we present it, let me know if you have feedback on copy!
