Skip to content

Conversation

annavik
Copy link
Member

@annavik annavik commented May 19, 2025

Summary

@mihow noticed that if a user is inspecting records from a different page than then first page, the page settings will remain when the filtering is updated. This can be a bit confusing, especially if data is no longer visible for the current page.

In this PR, we reset the current page when filters are modified from the UI. We also update the empty state component to consider page settings. To see no data because the current page is not the first page should be an edge case now, but it can still happen if page is set from URL.

Detailed Description

Screenshots

No data and page is not first page (see URL):
Screenshot 2025-05-19 at 11 23 59

No data and filters are set:
Screenshot 2025-05-19 at 11 27 41

No data:
Screenshot 2025-05-19 at 11 28 23

Copy link

netlify bot commented May 19, 2025

Deploy Preview for antenna-preview ready!

Name Link
🔨 Latest commit 99bb5f6
🔍 Latest deploy log https://app.netlify.com/projects/antenna-preview/deploys/682afa6e5612a00008201089
😎 Deploy Preview https://deploy-preview-854--antenna-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 75 (🔴 down 5 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@mihow mihow merged commit 015aaf6 into main May 23, 2025
6 checks passed
@mihow mihow deleted the fix/update-pagination-logic branch May 23, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants