Update pagination logic #854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@mihow noticed that if a user is inspecting records from a different page than then first page, the page settings will remain when the filtering is updated. This can be a bit confusing, especially if data is no longer visible for the current page.
In this PR, we reset the current page when filters are modified from the UI. We also update the empty state component to consider page settings. To see no data because the current page is not the first page should be an edge case now, but it can still happen if page is set from URL.
Detailed Description
Screenshots
No data and page is not first page (see URL):

No data and filters are set:

No data:
