Fix permission denied errors when accessing local files #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for antenna-preview canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses permission denied errors during testing by pinning MinIO and its client to specific versions that are known to work. Key changes include:
- Updating the MinIO image version in docker-compose.yml from "latest" to "RELEASE.2024-11-07T00-52-20Z".
- Updating the MinIO client image version in docker-compose.yml from the untagged image to "RELEASE.2025-03-12T17-29-24Z".
- Applying the same pinning for MinIO and its client in docker-compose.ci.yml.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Pinned minio and minio-init image versions to prevent permission errors. |
| docker-compose.ci.yml | Pinned minio and minio-init image versions for CI consistency. |
Comments suppressed due to low confidence (4)
docker-compose.yml:111
- [nitpick] Consider adding a comment explaining why this version is pinned, to assist future maintainers in understanding the context behind this change.
image: minio/minio:RELEASE.2024-11-07T00-52-20Z
docker-compose.yml:137
- [nitpick] Consider adding a comment to document why this specific client version is chosen, which would be useful when an update is required.
image: minio/mc:RELEASE.2025-03-12T17-29-24Z
docker-compose.ci.yml:31
- [nitpick] Consider including a comment to clarify the rationale for this version pinning in the CI configuration for consistency with local setups.
image: minio/minio:RELEASE.2024-11-07T00-52-20Z
docker-compose.ci.yml:37
- [nitpick] Consider adding a note explaining why this specific client version is pinned, providing context that may help in future updates.
image: minio/mc:RELEASE.2025-03-12T17-29-24Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test files were suddenly getting permission denied errors in the test suite and in any development environments that were recently created. This is because MinIO made some updates that broke our script that sets the test/local buckets to public after they are created. This PR pins MinIO to the last known working version. Further work should be done to update the commands and keep up-to-date with MinIO, but pinning the versions is a good idea nevertheless.
Deployment Notes
To fix this locally, run
docker compose pull minio minio-initand thendocker compose up -d. The changes do not apply to the production or staging environments because they used a hosted object storage service. If you haven't updated your Docker compose environment in a few months, then you shouldn't have run into this issue.Checklist