-
Notifications
You must be signed in to change notification settings - Fork 5
Setup default filters for project #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for antenna-preview failed. Why did it fail? →
|
Note: Consider adding a size filter here as well. Start with pixel percent, but if we add a size calibration for each device type (physical dimensions of the size of the target) then the filter can be physical units (centimeters). The goal being to automatically hide any moths/detections that are under X square centimeters. |
Yes I like that idea and I think this view will be the perfect place to add such a filter! I think we should try complete the first 2 filters before we add more though. Same for the "gap between monitoring sessions" setting. |
9f9fb41
to
c79960a
Compare
Adding some notes here from our call:
|
Thank you! 🙏 This is fully in line with my thoughts after the call as well. I plan to wrap this PR up at the beginning of next week. |
data.append('tag_ids', JSON.stringify(tags.map((tag) => tag.id))) | ||
|
||
return axios.post( | ||
mutationFn: ({ projectId, tags }: { projectId: string; tags: Tag[] }) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unrelated cleanup in this file
929aac6
to
72c36ad
Compare
Summary
In this PR we setup default filters for projects. This will help us present more relevant data for users and simplify view settings. The PR is in draft since we need to include BE changes and also a few remaining FE tweaks.
List of Changes
Sub Tasks
Related Issues
#873
#868
#237
#906 (the time gap between monitoring sessions should be configurable by users)
Detailed Description
Screenshots