Update command for importing taxa from external lists #939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: management command for updating fields on existing Taxa from CSV * feat: try another title for example occurrence image * feat: allow manual filter for showing taxa without occurrences * feat: allow sorting by reference image for better demos
* feat: add fields for Taxon cover images and Fieldguide ID * feat: add cover image fields to Taxon model for the UI
✅ Deploy Preview for antenna-preview canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the command for importing taxa from external lists by enhancing both the import and update functionality for taxonomic data management.
- Replaces hardcoded string rank values with TaxonRank enum constants for type safety
- Improves genus creation logic to handle existing taxa with different ranks
- Adds new update_taxa management command for updating existing taxa from CSV files
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ami/main/models.py | Updates add_genus_parents method to use TaxonRank enum and improve genus handling logic |
| ami/main/management/commands/update_taxa.py | Adds new management command for updating existing taxa from CSV files or URLs |
| ami/main/management/commands/import_taxa.py | Enhances import logic with better taxon creation, GBIF key handling, and return value updates |
Comments suppressed due to low confidence (1)
ami/main/management/commands/import_taxa.py:410
- The log message contains a grammatical error with 'to from'. It should be 'from {existing_value} to {incoming_value}'.
logger.info(
f"Changing {column} of {specific_taxon} to from {existing_value} to {incoming_value}"
)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mihow
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
this is only a configuration change, it does not alter the DB schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.