-
Notifications
You must be signed in to change notification settings - Fork 5
Make it easier for users to upload and explore captures #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
project=project, | ||
research_site=site, | ||
device=device, | ||
latitude=0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because I noticed the default project didn't pass validation and couldn't be saved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we keep Jobs in the menu for now until we have another prominent place for it? Everything else seems like a safe and welcome change!
/> | ||
<Route path="summary" element={<Summary />} /> | ||
<Route path="collections" element={<Collections />} /> | ||
<Route path="collections/:id" element={<CollectionDetails />} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup redirect route?
def get_or_create_default_device(project: "Project") -> "Device": | ||
"""Create a default device for a project.""" | ||
device, _created = Device.objects.get_or_create(name="Default device", project=project) | ||
device, _created = Device.objects.get_or_create(name="Default Device", project=project) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you preferred the other case!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I have no preference really, I just want things to be consistent. I noticed that for auto created entities, it seems we often use Capitalized Case (Default Station, All Images, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. What a great enhancement! Especially paired with the auto-processing. The image failure dialog worked for me as well.
I had to make 2 small fixes, but hopefully you approve, 'cause I am merging!
Thanks for the fixes Michael! I'm excited to have this merged! :) I noticed a few small minor I wanted to fix, I created a follow up PR: #947 |
Summary
As the first step towards a "project quick start", we make it easier for users to upload and explore captures. We also add a couple of empty states with suggested actions, to provide more guiding.
List of Changes
Related Issues
#923
Detailed Description
How to Test the Changes
I recommend to not test this from the preview deploy because, the backend seems a bit out of date in this environment (for example captures cannot be filtered by project). Instead, test from localhost (or first deploy the backend in the preview environment to match production).
Screenshots
Updated empty state for project gallery:

Updated empty state for project without captures:

New dialog to upload images:



Updated navigation:

Dedicated view for captures:

New links to captures:

