feat: Checkpoint locating support for running out-of-directory #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only the current directory is searched for the model checkpoint. While manual specification of the checkpoint path is possible, this requires that you A) remember to manually specify the path and B) know what the proper path is. To make running outside of the installation directory easier, add a fall-back to search the project path for the checkpoint file. This only applies only if you would otherwise get an error with the current behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the current working directory is searched for the model checkpoint. While manual specification of the checkpoint path is possible, this requires that you A) remember to manually specify the path and B) know what the proper path is.
To make running outside of the installation directory easier, add a fall-back to search the project path for the checkpoint file. (This is the location where the model is downloaded to if you naively follow the installation instructions as-written.)
This only applies only if you would otherwise get an error with the current behavior.