-
Notifications
You must be signed in to change notification settings - Fork 2
Added Linux vs. Windows note, llvm-symbolizer tip, various other minor notes and clarifications #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: doc-fixups
Are you sure you want to change the base?
Conversation
…r notes and clarifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just change those few things.
|
||
## Install | ||
|
||
> ⚠️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the Github markdown highlighting for this:
https://github.com/orgs/community/discussions/16925
- Always attempt to make the translated C file behave as closely as possible to the original C++ file! This greatly helps debugging and assures that Capstone behaves almost exactly the same as original LLVM. | ||
|
||
|
||
> ⚠️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
## Install | ||
|
||
> ⚠️ | ||
> Auto-Sync only runs on Linux, running on Windows is desirable but not a priority at the moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better just state it and link the issue: capstone-engine#2755.
So people have a place to check for updates and complain. Also below.
|
||
|
||
> ⚠️ | ||
> Refactoring an architecture to Auto-Sync is only possible on Linux, running on Windows is desirable but not a priority at the moment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your checklist for this pull request
Detailed description
I added a warning for both the README and the refactor guide that things only work on Linux, also added a tip about llvm-symbolizer to prettify the stacktraces that might result when you run commands that end up with LLVM tools crashing
Some miscellenous clarifications and additions were added, I expect I might update this PR so you might want to leave it unmerged for a couple of days to bundle all the changes together
Test plan
...
Closing issues
...