-
Notifications
You must be signed in to change notification settings - Fork 14
Fix cargo-gpu in build script failing when called by Miri or Clippy #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Miri works, but ran into some trouble with clippy: The install action when using a local path to rust-gpu seems to use the wrong toolchain for some reason. Will have a go at it myself.
|
Having the same problem with Clippy. Additionally, when testing locally just now (with
So, removing |
Cargo clippy now works as well. I also unified env var cleaning in spirv-builder and added env var debug printing, so any issues like this should be easier to debug in the future. @tuguzT feel free to give this branch another try :D |
@Firestar99, thanks, I'll try this out until tomorrow |
I tested this PR (and Additionally, I haven't known it is possible to use PR's git commit hash when linking to the original repository, could have simplified testing for me if I had known it earlier. |
You can also use local paths like |
Requires Rust-GPU/rust-gpu#335
See that PR for details as well
Resolves #93
Resolves #77