Skip to content

Commit 55e2ffb

Browse files
committed
difftest: cargo windows bug workaround, mirror all workspace dependencies
1 parent 344dd00 commit 55e2ffb

File tree

5 files changed

+16
-8
lines changed

5 files changed

+16
-8
lines changed

Cargo.toml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,15 +51,20 @@ spirv-tools = { version = "0.12", default-features = false }
5151
rustc_codegen_spirv = { path = "./crates/rustc_codegen_spirv", version = "=0.9.0", default-features = false }
5252
rustc_codegen_spirv-types = { path = "./crates/rustc_codegen_spirv-types", version = "=0.9.0" }
5353
rustc_codegen_spirv-target-specs = { path = "crates/rustc_codegen_spirv-target-specs", version = "=0.9.0" }
54+
55+
# difftest libraries mirrored from difftest workspace
56+
difftest = { path = "tests/difftests/tests/lib" }
5457
difftest-runner = { path = "tests/difftests/runner", default-features = false }
55-
tracing = "0.1"
56-
tracing-subscriber = { version = "0.3.3", features = ["env-filter", "json"] }
58+
difftest-types = { path = "tests/difftests/types" }
5759

5860
# External dependencies that need to be mentioned more than once.
61+
tracing = "0.1"
62+
tracing-subscriber = { version = "0.3.3", features = ["env-filter", "json"] }
5963
num-traits = { version = "0.2.15", default-features = false }
6064
glam = { version = ">=0.22, <=0.30", default-features = false }
6165
# libm 0.2.12 is a breaking change with new intrinsics
6266
libm = { version = ">=0.2.5, <=0.2.11", default-features = false }
67+
bytemuck = { version = "1.23", features = ["derive"] }
6368

6469
# Enable incremental by default in release mode.
6570
[profile.release]

crates/rustc_codegen_spirv/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ skip-toolchain-check = []
3434
# HACK(eddyb) these only exist to unify features across dependency trees,
3535
# in order to avoid multiple separate instances of `rustc_codegen_spirv`.
3636
ahash = { version = "0.8.11", features = ["no-rng"] }
37-
bytemuck = { version = "1.20.0", features = ["aarch64_simd", "derive"] }
37+
bytemuck = { workspace = true, features = ["aarch64_simd"] }
3838
log = { version = "0.4.22", features = ["std"] }
3939
regex = { version = "1", features = ["perf"] }
4040
rustix = { version = "0.38.42", features = ["all-apis"] }

crates/spirv-std/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ workspace = true
1414
spirv-std-types.workspace = true
1515
spirv-std-macros.workspace = true
1616
bitflags = "1.2.1"
17-
bytemuck = { version = "1.18.0", features = ["derive"], optional = true }
17+
bytemuck = { workspace = true, optional = true }
1818

1919
[target.'cfg(target_arch = "spirv")'.dependencies]
2020
num-traits = { workspace = true, features = ["libm"] }

tests/difftests/tests/Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/difftests/tests/Cargo.toml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,18 @@ unexpected_cfgs = { level = "allow", check-cfg = [
4545
'cfg(target_arch, values("spirv"))'
4646
] }
4747

48+
# Cargo Windows bug: workspace dependencies of crates.io dependencies are resolved
49+
# incorrectly in the root workspace instead of this difftest workspace. So all
50+
# workspace dependencies here must be mirrored into the root workspace as well.
4851
[workspace.dependencies]
4952
spirv-builder = { path = "../../../crates/spirv-builder", default-features = false }
5053
spirv-std = { path = "../../../crates/spirv-std", version = "=0.9.0" }
5154
difftest = { path = "lib" }
5255
difftest-types = { path = "../types" }
5356
# External dependencies that need to be mentioned more than once.
5457
num-traits = { version = "0.2.15", default-features = false }
55-
glam = { version = ">=0.22, <=0.29", default-features = false }
56-
bytemuck = { version = "1.14", features = ["derive"] }
58+
glam = { version = ">=0.22, <=0.30", default-features = false }
59+
bytemuck = { version = "1.23", features = ["derive"] }
5760

5861
# Enable incremental by default in release mode.
5962
[profile.release]

0 commit comments

Comments
 (0)