Skip to content

print: attempt to improve GlobalVar printing by using named arguments. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eddyb
Copy link
Collaborator

@eddyb eddyb commented Aug 4, 2025

Pretty small aesthetic improvement (or at least making global vars more like other constructs where pretty-printing relies on "named arguments"), that happened to be independent enough to land separately.

Quick examples (tho note that data(...) blobs and &F... pointers require other other changes):
image
image

I don't have a "before" on hand for either of those, but they involved layout(...) around size/align, the spv.StorageClass.Private would be separate with a keyword, and init might've used = ....
(if there is more interest, I can spend extra time on that, but this is IMO not that important)

@eddyb eddyb requested a review from a team August 4, 2025 09:01
@eddyb eddyb marked this pull request as draft August 8, 2025 18:04
@eddyb eddyb marked this pull request as ready for review August 11, 2025 15:17
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, only used this once myself and you are probably the main/only consumer right now 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants