ml-dsa: add VerifyingKey::compute_mu()
#1074
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
ml-dsa-compute-mu
branch
from
e5bcb33 to
3e012fd
Compare
daxpedda
force-pushed
the
ml-dsa-compute-mu
branch
from
3e012fd to
8155e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #1064 mostly resolves any need to add dedicated methods to compute µ for ML-DSA, one scenario was still uncovered: being able to use external-µ signing with e.g. HSMs. In which case we don't have access to the secret key, but we can compute µ with the help of the public key.
So we add a
VerifyingKey::compute_mu()method that facilitates that.This specifically targets
ML-DSA.Signand notML-DSA.Sign_internal. I can add another method for that if desired.Resolves #1060.
Builds on top of #1073.