Feature/rework updatemanager #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move UpdateDistributor._update initialization to constructor - Add 'readonly' keyword to LongpollingUpdateTracker._observers - Add 'readonly' keyword to UpdateDistributor._updateInfos - Add 'sealed' keyword to UpdateTypeInfo - Add 'sealed' keyword to DisposableAction - Call Dispose method for LongpollingUpdateTracker._cancellationTokenSource - Add class constraint to TOut parameter in CustomSubject class
Contributor
Author
|
I also found a critical bug related to disposing subscriptions and restoring the connection after the LongpollingTracker catches an exception. I'm working on it, but it's taking longer than expected. I'll let you know once I finish. |
…ing issues. - Added Observable operators: - `DoOnDispose`: Executes an action when the observable is disposed. - `DoOnSubscribe`: Executes an action when a new observer subscribes. - `Select`: Applies a function to each item in the observable and returns the result of that function. - `Switch`: Switches to the latest observable sequence when the source emits a new value. - `Where`: Filters the observable sequence based on a predicate. - Added `ReactiveProperty` for easier state management. - Removed unnecessary `CustomSubject` and `UpdateSubject`. - Fixed exception handling in `LongpollingUpdateTracker`.
Contributor
Author
|
Done. I had to implement several RX operators to avoid external dependencies and solve the task. They might be useful in other parts of the library as well, since the library aims to minimize external dependencies. I've been testing the updated code with both fake and real connection exceptions, and so far, I haven't broken it. |
Replaced `DoOnDispose` with `Finally` in `UpdateDistributor` to fix subscriber tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for multiple subscriptions to the same
UpdateTypeApply Sonar recommendations from PR #71