Nearby Bus Stops Inaccurate locations

[Ryan-Gordon]

Currently the nearby route takes in the parameters and queries the API but doesn't find stops close to the co-ordinates. For example, taking the point of GMIT the API returned stops in Dublin.

A problem with the distance calculation possibly.

[Ryan-Gordon]

Think I figured out the issue:
Its two fold
First is I was messing up the longitude and latitude co ordinates on some lines.
Second (more importantly) the results are being resolved too early. This is an issue with the forEach statement but its good to now have an idea of where the problem is coming from.

[Ryan-Gordon]

Still no joy, got some good advice to try using Map instead of forEach as forEach doesn't seem to play nice with async stuff

The result of that was blank objects being returned
Also looking at the forEach package from p-iteration which seems to be very good for the use case

[Ryan-Gordon]

The previous solution for this wasn't working because of how we sort things. Previously the sort result was the difference between the two stops distance.
This was the wrong approach and something like this should work better :

           if (s1 > s2) {
                return 1;
            }
        
            if (s1 < s2) {
                return -1;
            }
        
            return 0;