chore: Improve Exception Handling and Accessors to Response/Request #529
+248
−238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ai-sdk-java into exceptions-with-httpresponse
newtork
commented
Aug 6, 2025
| @@ -102,7 +101,7 @@ public static void send(@Nonnull final ResponseBodyEmitter emitter, @Nonnull fin | |||
| try { | |||
| emitter.send(chunk); | |||
| } catch (final IOException e) { | |||
| log.error(Arrays.toString(e.getStackTrace())); | |||
| log.error("Failed to send chunk: {}", e.getMessage(), e); | |||
There was a problem hiding this comment.
Minor drive-by change.
9 tasks
rpanackal
reviewed
Aug 12, 2025
| @Getter(onMethod_ = @Beta, value = AccessLevel.PROTECTED) | ||
| @Setter(onMethod_ = @Beta, value = AccessLevel.PROTECTED) | ||
| ClientError clientError; | ||
| @Getter(onMethod_ = @Beta, value = AccessLevel.PUBLIC) |
There was a problem hiding this comment.
(Question/Suggestion)
Should getClientError() remain protected? As far as I see, ClientError is an internal wrapper for error response.
For users, there exist a getErrorResponse() in module specific exceptions like OpenAiClientException to shortcut access to the error response.
I feel like getErrorResponse() is convenient than getClientError() and would reduce confusion. Having both method public may be redundant?
There was a problem hiding this comment.
The following API is available
catch(OrchestrationClientException e) {
e.getMessage(); // default
e.getCause(); // default
e.getHttpResponse(); // ClassicHttpResponse
e.getHttpRequest(); // ClassicHttpRequest
e.getClientError().getMessage(); // convenient message
e.getErrorResponse(); // ErrorResponse (model class)
e.getErrorResponseStreaming(); // ErrorResponseStreaming (model class)
}The e.getClientError().getMessage() is the reason.
However I would also prefer if it wasn't split.
…esponse # Conflicts: # docs/release_notes.md # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClientException.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationExceptionFactory.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationHttpExecutor.java
…to exceptions-with-httpresponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://github.com/SAP/ai-sdk-java-backlog/issues/290
Since we removed logging of HTTP request/responses from our code, we want to ease troubleshooting in the future.
Feature scope:
pubicaccessorDefinition of Done
Aligned changes with the JavaScript SDKDocumentation updated