Skip to content

Commit 5787620

Browse files
committed
fix(list) show correct URLs in html5-list -d -u
- use `HTML5_RUNTIME_URL` in `html5-list -d -u` - fix #31 - change `cpp` to `launchpad` - update changelog - update version to 1.4.1
1 parent d5a8c9d commit 5787620

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

CHANGELOG.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,15 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
66

77
## [Unreleased]
88

9+
## [1.4.1] - 2020-04-21
10+
11+
### Changed
12+
- Default `HTML5_RUNTIME_URL` is changed to `https://<tenant>.launchpad.<landscape_url>`
13+
14+
### Fixed
15+
- List destination aplication URLs `html5-list -d -u` now uses `HTML5_RUNTIME_URL` ([#31](https://github.com/SAP/cf-html5-apps-repo-cli-plugin/issues/31))
16+
17+
## [1.4.0] - 2020-03-31
918
### Added
1019
- Retry for service instance and keys deletion added ([#21](https://github.com/SAP/cf-html5-apps-repo-cli-plugin/issues/21))
1120
- Error handling for service broker errors added ([#16](https://github.com/SAP/cf-html5-apps-repo-cli-plugin/issues/16))
@@ -14,8 +23,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
1423
- Support of `--destination` flag for `html5-list`
1524
- Support of `--destination` flag for `html5-delete`
1625
- Support custom HTML5 runtime for business service destinations with `HTML5_RUNTIME_URL`
17-
environment variable (default: `https://<tenant>.cpp.<landscape_url>`)
18-
- Support of `--service` flag for `html5-push`
26+
environment variable (default: `https://<tenant>.launchpad.<landscape_url>`)
27+
- Support of `--service` flag for `html5-push`
28+
- Delete multiple service instances by name prefix with `cf html5-delete -n <name_prefix>*`
29+
- Show business service destinations that missing or point to not existing `app-host-id` in `cf html5-list -d`
1930

2031
### Changed
2132
- List command `html5-list` now checks if first and the only argument passed is an app-host-id,

commands/html5_list_command.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ func (c *ListCommand) ListDestinationApps(showUrls bool) ExecutionStatus {
251251
row[4] = destination.Name
252252
row[5] = application.ChangedOn
253253
if showUrls {
254-
row[6] = destination.URL + "/" + strings.Replace(serviceName, ".", "", -1) +
254+
row[6] = html5Context.RuntimeURL + "/" + strings.Replace(serviceName, ".", "", -1) +
255255
"." + application.ApplicationName + "-" + application.ApplicationVersion + "/"
256256
}
257257
rows = append(rows, row)
@@ -630,7 +630,7 @@ func (c *ListCommand) ListApps(appHostGUID *string) ExecutionStatus {
630630
} else {
631631
// Use service instance with provided app-host-id
632632
appHostServiceInstances = []models.CFServiceInstance{
633-
models.CFServiceInstance{
633+
{
634634
GUID: *appHostGUID,
635635
Name: "-",
636636
LastOperation: models.CFLastOperation{

html5_plugin.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import (
1616
"github.com/cloudfoundry/cli/plugin"
1717
)
1818

19-
// Version is the version of the CLI plugin. It is injected on linking time.
20-
var Version = "1.4.0"
19+
// Version is the version of the CLI plugin.
20+
var Version = "1.4.1"
2121

2222
// HTML5Plugin represents a cf CLI plugin for working with HTML5 Application Repository service
2323
type HTML5Plugin struct{}

0 commit comments

Comments
 (0)