fix(odata-service-inquirer):Hide credentials prompts if client not valid (#3765)

* fix(odata-service-inquirer):Hide credentials prompts if client not valid

#3764

* Adds cset

Author: IainSAP

.changeset/old-olives-own.md

@@ -0,0 +1,5 @@
+---
+'@sap-ux/odata-service-inquirer': patch
+---
+
+Fixes creds prompt shown when sap client invalid (on-prem url/client only)

packages/odata-service-inquirer/src/prompts/datasources/sap-system/abap-on-prem/questions.ts

@@ -107,6 +107,9 @@ export function getAbapOnPremSystemQuestions(
                             client
                         );
                         if (existingBackend) {
+                            // Prevents further prompts by setting the client to invalid
+                            // This is a temp workaround until multiple systems with the same url/client key is supported
+                            sapClientRef.isValid = false;
                             return t('prompts.validationMessages.backendSystemExistsWarning', {
                                 backendName: existingBackend.name
                             });

packages/odata-service-inquirer/src/prompts/datasources/sap-system/credentials/questions.ts

@@ -45,7 +45,9 @@ export function getCredentialsPrompts<T extends Answers>(
         {
             when: async () => {
                 authRequired = await connectionValidator.isAuthRequired();
-                return connectionValidator.systemAuthType === 'basic' && authRequired;
+                return (
+                    connectionValidator.systemAuthType === 'basic' && authRequired && (!sapClient || sapClient.isValid)
+                );
             },
             type: 'input',
             name: usernamePromptName,
@@ -57,7 +59,8 @@ export function getCredentialsPrompts<T extends Answers>(
             validate: (user: string) => user?.length > 0
         } as InputQuestion<T>,
         {
-            when: () => !!(connectionValidator.systemAuthType === 'basic' && authRequired),
+            when: () =>
+                !!(connectionValidator.systemAuthType === 'basic' && authRequired && (!sapClient || sapClient.isValid)),
             type: 'password',
             guiOptions: {
                 mandatory: true,
@@ -74,7 +77,7 @@ export function getCredentialsPrompts<T extends Answers>(
                         connectionValidator.validatedUrl &&
                         answers?.[usernamePromptName] &&
                         password &&
-                        (sapClient?.isValid || !sapClient)
+                        (!sapClient || sapClient.isValid)
                     )
                 ) {
                     return false;

packages/odata-service-inquirer/test/unit/prompts/sap-system/credentials/questions.test.ts

@@ -269,4 +269,35 @@ describe('Test credentials prompts', () => {
             } as NewSystemAnswers)
         ).toBeUndefined();
     });
+
+    test('should not show credentials prompts if the sap client reference is invalid', async () => {
+        const connectionValidator = new ConnectionValidator();
+        connectionValidatorMock.validity = {
+            authenticated: false,
+            authRequired: true,
+            reachable: true
+        };
+        connectionValidatorMock.isAuthRequired.mockReturnValue(true);
+        connectionValidatorMock.systemAuthType = 'basic';
+        connectionValidatorMock.validatedUrl = 'http://abap01:1234';
+        const sapClientRef = {
+            sapClient: '999',
+            isValid: true
+        };
+
+        const credentialsPrompts = getCredentialsPrompts(connectionValidator, promptNamespace, sapClientRef);
+        const userNamePrompt = credentialsPrompts.find(
+            (question) => question.name === systemUsernamePromptName
+        ) as InputQuestion;
+        const passwordPrompt = credentialsPrompts.find(
+            (question) => question.name === systemPasswordPromptName
+        ) as PasswordQuestion;
+
+        expect(await (userNamePrompt?.when as Function)()).toBe(true);
+        expect(await (passwordPrompt?.when as Function)()).toBe(true);
+
+        sapClientRef.isValid = false;
+        expect(await (userNamePrompt?.when as Function)()).toBe(false);
+        expect(await (passwordPrompt?.when as Function)()).toBe(false);
+    });
 });