feat: Adapt CF projects' structure to work with preview-middleware #3703
+391
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikmace
added
feature
🦋 Changeset detectedLatest commit: d06b55b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmilko01
reviewed
Oct 8, 2025
.changeset/eighty-coins-sip.md
Outdated
Comment on lines
2
to
3
| '@sap-ux/project-input-validator': patch | ||
| '@sap-ux/generator-adp': patch |
There was a problem hiding this comment.
- Is it needed for the
@sap-ux/project-input-validatorto be added in the changeset? I couldn't see any changes to the package? - Similar for
@sap-ux/generator-adp, may be there is no need for patch to be released for a snapshot update only?
There was a problem hiding this comment.
Hmm, this is what was recommended by cset. I'll remove @sap-ux/project-input-validator. The @sap-ux/generator-adp is needed because it consumes the @sap-ux/adp-tooling package, and it will be included anyway in here:
lfindlaysap
requested changes
Oct 13, 2025
lfindlaysap
previously approved these changes
Oct 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat for #3699.
.adp/config.json.fiori-previewandfiori-proxymiddleware.startscript for starting the preview in a new tab.