[FEATURE] Support Lean-App card generation for CAP based Fiori applications #3719
Conversation
🦋 Changeset detectedLatest commit: 10b5997 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
…SAP/open-ux-tools into feat/1304/card-gen-for-cap-apps
|
@Singham-24 please don't use internal URLs in an external PR. |
| const webappPath = await getWebappPath(path.resolve(), this.fs); | ||
| const i18nPath = this.manifest['sap.app'].i18n as string; | ||
| const filePath = i18nPath ? join(webappPath, i18nPath) : join(webappPath, 'i18n', 'i18n.properties'); | ||
| const i18nConfig = this.manifest['sap.app'].i18n; |
There was a problem hiding this comment.
General question: What does the i18n adjustments have to do with card generation for CAP based apps?
There was a problem hiding this comment.
Earlier, the implementation only handled the default i18n.properties file and did not account for scenarios where the manifest defined i18n configurations using a bundleUrl.
There was a problem hiding this comment.
I understand that. My question was rather what the i18n adjustment has to do with general cards support for CAP apps. According to this PR because of the missing object support for the i18n property, CAP apps have not been supported. But that's not true. Card generation fro CAP apps has been disabled in #3349 because you cannot deploy the generated cards / the generated cards will be ignored by the FLP. That only works for ABAP based FLPs. So basically my questions are:
- Did you verify that the non-ABAP FLP(s) now also support cards? If not, why delete the restriction in this PR?
- Why is this i18n change related to CAP at all? The type of the i18n property has been
string | objectall the time. That's nothing CAP specific. So that part rather looks like a bugfix to me.
…SAP/open-ux-tools into feat/1304/card-gen-for-cap-apps
…SAP/open-ux-tools into feat/1304/card-gen-for-cap-apps
|
| app.use(flp.router); | ||
|
|
||
| server = supertest(app); | ||
| return { flp, app }; |
There was a problem hiding this comment.
The return parameters seem to be not use anywhere. Can this be deleted?
2 participants
This update adds support for launching the Card Generation Dialog in CAP-based Fiori applications, aligning it with existing functionality available for RAP-based apps. CAP apps can now generate, save, and share cards using the same flow.
Summary of Changes :-
Enabled card generation trigger for CAP-based projects
Reused existing logic for dialog handling
Ensured consistent behavior across RAP and CAP apps