Skip to content

fix: CF integration tests and sonar issues #3739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 22, 2025
Merged

fix: CF integration tests and sonar issues #3739

merged 8 commits into from
Oct 22, 2025

Conversation

@nikmace
Copy link
Contributor

@nikmace nikmace commented Oct 16, 2025 •
edited
Loading

Fix for #3734.

  • Adds the CF integration test and fixes tests that failed before.
  • Fixes sonar issue with a method having too many parameters.

@nikmace nikmace self-assigned this Oct 16, 2025
@nikmace nikmace added adp-tooling generator-adp @sap-ux/generator-adp labels Oct 16, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 47ba81e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sap-ux/generator-adp Patch
@sap-ux/adp-tooling Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace requested a review from a team as a code owner October 16, 2025 11:23
testojs
testojs approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code looks good
  • changeset OK
  • good test coverage
  • not tested manually

mmilko01
mmilko01 approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@mmilko01 mmilko01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset OK
Good test coverage
Changes look good
Did not test manually

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nikmace nikmace merged commit 27fb53e into main Oct 22, 2025
16 checks passed
@nikmace nikmace deleted the fix/3734/tests-and-lint-errors branch October 22, 2025 12:34
devinea added a commit that referenced this pull request Oct 22, 2025
@devinea
Merge remote-tracking branch 'origin/main' into devDep_updates
d1c64b4 
* origin/main:
  merge from main (#3761)
  Generate Manual test case for ADP Test (#3602)
  chore: apply latest changesets
  fix: CF integration tests and sonar issues (#3739)
devinea added a commit that referenced this pull request Oct 22, 2025
@devinea
Merge remote-tracking branch 'origin/main' into devDep_updates
4190420 
* origin/main:
  merge from main (#3761)
  Generate Manual test case for ADP Test (#3602)
  chore: apply latest changesets
  fix: CF integration tests and sonar issues (#3739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@testojs testojs testojs approved these changes

@mmilko01 mmilko01 mmilko01 approved these changes

Assignees

@nikmace nikmace

Labels

adp-tooling generator-adp @sap-ux/generator-adp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikmace @testojs @mmilko01