-
Notifications
You must be signed in to change notification settings - Fork 50
TBI(MCP) Add new tool get_fiori_rules to include default rules #3748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2eb4b92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nit-pick questions regarding where to store the files 🙈
@@ -0,0 +1,10 @@ | |||
import fioriRulesContent from '../fiori-rules.md'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this file is in the /tools
folder. Shouldn't there be a /prompts
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is shared between prompt and tools. I could move to a common folder?
export { listFunctionalities } from './list-functionalities'; | ||
export { getFunctionalityDetails } from './get-functionality-details'; | ||
export { executeFunctionality } from './execute-functionality'; | ||
export { getFioriRules } from './get-fiori-rules'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically same question /prompts
vs /tools
folder
- Data model requirements (entities, navigation properties, UUIDs) | ||
- Sample data format requirements | ||
- Preview and testing guidelines | ||
You SHOULD use this tool when starting any Fiori application creation or modification task.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should or must?
TBI(MCP) Add new tool get_fiori_rules to include default rules