Skip to content

Conversation

devinea
Copy link
Member

@devinea devinea commented Oct 16, 2025

TBI(MCP) Add new tool get_fiori_rules to include default rules

Copy link

changeset-bot bot commented Oct 16, 2025

🦋 Changeset detected

Latest commit: 2eb4b92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nit-pick questions regarding where to store the files 🙈

@@ -0,0 +1,10 @@
import fioriRulesContent from '../fiori-rules.md';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this file is in the /tools folder. Shouldn't there be a /prompts folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is shared between prompt and tools. I could move to a common folder?

export { listFunctionalities } from './list-functionalities';
export { getFunctionalityDetails } from './get-functionality-details';
export { executeFunctionality } from './execute-functionality';
export { getFioriRules } from './get-fiori-rules';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically same question /prompts vs /tools folder

@devinea devinea marked this pull request as ready for review October 17, 2025 07:20
@heimwege heimwege added the fiori-mcp @sap-ux/fiori-mcp label Oct 17, 2025
- Data model requirements (entities, navigation properties, UUIDs)
- Sample data format requirements
- Preview and testing guidelines
You SHOULD use this tool when starting any Fiori application creation or modification task.`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should or must?

@devinea devinea requested a review from heimwege October 18, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fiori-mcp @sap-ux/fiori-mcp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants