fix(odata-service-inquirer): transformations check #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0fb0c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
IainSAP
previously approved these changes
Oct 17, 2025
Contributor
IainSAP
left a comment
IainSAP
left a comment
There was a problem hiding this comment.
Thanks @korotkovao
- Updates as defined by new requirements
- tests updates
- cset included
IainSAP
previously approved these changes
Oct 17, 2025
Contributor
IainSAP
left a comment
IainSAP
left a comment
There was a problem hiding this comment.
Thx @korotkovao
- Reapproving
IainSAP
reviewed
Oct 20, 2025
IainSAP
reviewed
Oct 20, 2025
IainSAP
reviewed
Oct 20, 2025
IainSAP
approved these changes
Oct 20, 2025
docirl
approved these changes
Oct 20, 2025
Contributor
docirl
left a comment
docirl
left a comment
There was a problem hiding this comment.
- changes look good
- tests updated
- not tested manually
|
Contributor
Author
korotkovao
deleted the
fix/odata-service-inquirer/36030-default-table-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to internal issue 36030
Change for supporting 8 transformations instead of 9 - filter, identity, orderby, skip, top, groupby, aggregate, concat.
When a service has both Hierarchical and analytical with 8 transformations , Analytical table type needs to be selected, otherwise it will be hierarchical
When selecting an ALP template, the entities filtered need to be compliant with Analytical usage ( @Aggregation.ApplySupported with 8 transformations for ABAP and only @Aggregation.ApplySupported for CAP)