Skip to content

Adding two missing possibilities for ValueListParameter #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

frij-aws
Copy link
Contributor

@frij-aws frij-aws commented Apr 1, 2025

Adding two missing possibilities for ValueListParameter from from the SAP common vocabulary list

@phanak-sap
Copy link
Contributor

Hi frij-aws.

Thx for pull request. Straightforward and simple.

  1. I am quite surprised no test was actually need to be updated as well - clearly missing some automation here :)

  2. Am I correct that we have in pyodata already hardcoded things that are SAP specific in a model.py, that tries to be covering Odata specification and adding SAP-only things ideally to different, isolated module like vendors/SAP.py? :)

Both are just open question, I am willing to merge as is.

@frij-aws
Copy link
Contributor Author

frij-aws commented Apr 3, 2025

To be honest I do not know what these constants are for or what they do, so I'm not 100% sure about the answers to your questions -- although I agree on (2) that it smells bad to have SAP-specific stuff in model.py. :)

@phanak-sap phanak-sap merged commit 24d8135 into SAP:master Apr 26, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants