Skip to content

fix(dts-generator): in function typedefs, build parameters properly #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(dts-generator): in function typedefs, build parameters properly #508

wants to merge 1 commit into from

Conversation

akudev
Copy link
Contributor

@akudev akudev commented Jun 6, 2025

Fixes #502

@akudev akudev marked this pull request as draft June 6, 2025 16:15
@akudev
Copy link
Contributor Author

akudev commented Jun 6, 2025

NOT YET READY

This does generate the complete structure with resolve and reject, but their types are function() : void, which is invalid TypeScript and coming exactly from JSDoc. Either the source in UI5 Dialog needs to be adapted or the generator needs to reformat the type as it happens for https://github.com/SAP/openui5/blob/f15b7a07506ef1b085f35a5aa43c0d0856dc41e0/src/sap.ui.core/src/sap/ui/core/Core.js#L3325 where the type in dts is () => void.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type definitions not updated from JSdoc
1 participant
@akudev