Refactor public interface #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't rely on nonstandard extensions (such as M_PI) - Don't rely on transitive includes for some standard types - Switch to C++20 so we can use std::numbers
from 6b575523ce838fc13517d1a8021ce4883efc29c1
These come from a external project and shouldn't be re-formatted.
This is a separate commit for git's rename tracking
timniederhausen
force-pushed
the
feature/refactor
branch
2 times, most recently
from
cf71fd9 to
806fa2d
Compare
timniederhausen
force-pushed
the
feature/refactor
branch
2 times, most recently
from
da5c325 to
3b18149
Compare
Now that our headers are properly namespaced, there's no need to prefix their filenames with gp_ or end them with _c to avoid name clashes with library users.
timniederhausen
force-pushed
the
feature/refactor
branch
from
3b18149 to
67ce1fc
Compare
They're not costly in terms of workflow minutes so we can just do that.
timniederhausen
force-pushed
the
feature/refactor
branch
from
71b86a9 to
64035d8
Compare
|
The CI shows, inter alia, shadowing warnings. Pls remove them before we merge. |
timniederhausen
force-pushed
the
feature/refactor
branch
3 times, most recently
from
5df0f3e to
5a44767
Compare
in lieu of std::vector<T> for tiles of type T. The advantage of this is: - tiles are easily HPX-serializable and we can put them into HPX components - we can perhaps later add support for automatic GPU upload
timniederhausen
force-pushed
the
feature/refactor
branch
from
5a44767 to
bfcde8a
Compare
Powered by HPX's performance counter library. Since this library is only built if networking != none, guard against it being missing.
timniederhausen
force-pushed
the
feature/refactor
branch
from
bfcde8a to
1837fda
Compare
timniederhausen
force-pushed
the
feature/refactor
branch
2 times, most recently
from
a4a3541 to
504ddee
Compare
Quite a few functions took `int` parameters just to cast them to `std::size_t` everywhere.
timniederhausen
force-pushed
the
feature/refactor
branch
from
504ddee to
3df5ebd
Compare
|
This PR also adds Windows support. Please add respective a section and instructions into the README.md |
|
The refactor currently only works for the CPU code. Compilation for the GPU support fails due to multiple namespace errors. |
Extends our performance counter to track #calls and runtime.
Algorithms supporting different schedulers are templates now. Consequently, they had to be moved from .cpp to .hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged after the vcpkg / Windows PR.
So far:
gprat/directory.const_tile_data<T>&mutable_tile_data<T>as NUMA-aware replacement forstd::vector<T>(where T in float,double)Outstanding:
gprat/directory.