RPATH for targets #189
RPATH for targets #189
Conversation
CMakeLists.txt
Outdated
| ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_INSTALL_BINDIR} | ||
| ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR} | ||
| ) | ||
| set(CMAKE_INSTALL_RPATH $ORIGIN $ORIGIN/${relDirRInstallPath}) |
There was a problem hiding this comment.
It points to the binary/library directory and doesn't need to be set. More here: https://stackoverflow.com/questions/77347280/what-is-the-origin-token-in-cmake
CMakeLists.txt
Outdated
| if(${PROJECT_NAME}_ENABLE_GNUINSTALLDIRS) # for GNUInstallDirs | ||
| file(RELATIVE_PATH relDirRInstallPath | ||
| ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_INSTALL_BINDIR} | ||
| ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR} | ||
| ) | ||
| set(CMAKE_INSTALL_RPATH $ORIGIN $ORIGIN/${relDirRInstallPath}) | ||
| else() | ||
| # not robust | ||
| set(CMAKE_INSTALL_RPATH $ORIGIN $ORIGIN/../lib64 $ORIGIN/../lib) | ||
| endif() |
There was a problem hiding this comment.
It may be best to put this logic into cmake/bob.cmake.
| "${CMAKE_INSTALL_PREFIX}/lib" isSystemDir) | ||
| if("${isSystemDir}" STREQUAL "-1") | ||
| set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib" PARENT_SCOPE) | ||
| set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/lib" "${CMAKE_INSTALL_PREFIX}/lib64" PARENT_SCOPE) |
There was a problem hiding this comment.
Adding the lib64 here solved the issue. @cwsmith, is it fine? Or, is there any better way to do it?
There was a problem hiding this comment.
bob.cmake will set BOB_LIB_DESTINATION based on whether or not GNUInstallDirs is enabled (default is on... I've never seen a build with it off...):
Lines 77 to 90 in e8fe57b
Given that, I think it would be best to do the following:
set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/${BOB_LIB_DESTINATION}" PARENT_SCOPE)
Can you give this a shot to see if it works as expected?
There was a problem hiding this comment.
I tried it. Just checked again. It does not add the lib64 or even lib as RPATH in the binary. Here's the RPATH the installed binary has
Library rpath: [/opt/scorec/spack/rhel9/v0201_4/install/linux-rhel9-x86_64/gcc-7.4.0/gcc-12.3.0-iil3lnovyknyxf7pec36wljem3fntjd5/lib64:/users/hasanm4/lore/wsources/omega_h/build-kokkos/install/:/users/hasanm4/lore/wsources/omega_h/kokkos/build-omp/install/lib64:/opt/scorec/spack/rhel9/v0201_4/install/linux-rhel9-x86_64/gcc-12.3.0/zlib-1.2.13-mjocrm2cwyth6kvpmj3yrg52ulwd64ow/lib]
2 participants
I have added
INSTALL_RPATHso that the utilities do not needLD_LIBRARY_PATHset to point to the lib directory.